[Bug 222338] Review Request: initng-conf-gtk - InitNG configuration and control utility

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: initng-conf-gtk - InitNG configuration and control utility


https://bugzilla.redhat.com/show_bug.cgi?id=222338


dm at mensa.se changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #259651|0                           |1
        is obsolete|                            |




------- Additional Comments From dm at mensa.se  2007-12-15 07:00 EST -------
Created an attachment (id=289685)
 --> (https://bugzilla.redhat.com/attachment.cgi?id=289685&action=view)
initng-conf-gtk 0.5.1-2 spec file

(In reply to comment #13)
> Sorry for taking so long, Daniel.

No problem. It isn't like I've been very active either ;-)
 
> You haven't posted a link to a new srpm file but I assume the old location is

> still valid, hence I'm using
>
http://download.initng.org/initng-gui/initng-conf-gtk/initng-conf-gtk-0.5.1-1.fc8.src.rpm

> for the continued review.

Quite right. And the new one now is
http://download.initng.org/initng-gui/initng-conf-gtk/initng-conf-gtk-0.5.1-2.fc8.src.rpm


>  - initng-conf-gtk.src: W: strange-permission initng-conf-gtk.spec 0755
> Please remove the executable bit from the spec file.

This one is strange. I'm quite sure I've never set the execute bit on the spec
file. Seems that the error is gone now though...
 
> E Consistent use of macros:
> Please use %{__rm} for rm and %{__ln_s} for 'ln -s', %{__mkdir} for mkdir,
> %{__make} for make, ${_bindir} for /usr/bin

Fixed.

> To preserve timestamps on files upon copying, always add the -p option to
both
> cp and install, additionally change the 'make install' to
> make install DESTDIR=$RPM_BUILD_ROOT INSTALL="%{__install} -p"

Fixed. Didn't find any cp or install in the spec file though...

> - gtk-update-icon-cache must be executed with '|| :' at the end (instead of
';')
> so %post doesn't fail completely if something goes wrong

Fixed
 
> - update-desktop-database is missing in %post

Fixed
 
> If a package specifies no vendor, use "fedora" as vendor id, see
>
http://fedoraproject.org/wiki/Packaging/Guidelines#head-d559ee7363418a5840ce63090c608c991cd39ce6

> Thus what Yuichi wrote in Comment #2 is wrong.

Ah! I was sure I had seen that somewhere... Fixed again.
 
> Although rpmlint doesn't complain about this, you're mixing up spaces and
tabs
> in your spec file scripts. Please use one of them consistently.

Emacs doesn't like me. Think it's fixed now though.
 
> Please replace
> {_datadir}/%{name}/%{name}.glade
> with
> {_datadir}/%{name}

Fixed
 
> Aside from the issues left, the new source package in fact produces a working

> program. 

Did that sound like you're surprised? ;-)


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.