[Bug 225671] Merge Review: curl

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: curl


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225671


ruben at rubenkerkhof.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|ruben at rubenkerkhof.com      |jnovy at redhat.com
               Flag|fedora-review?              |fedora-review-




------- Additional Comments From ruben at rubenkerkhof.com  2007-02-03 11:08 EST -------
* RPM name is OK
* Source curl-7.16.1.tar.bz2 is the same as upstream
* This is the latest version
* Builds fine in mock
* File list of curl-devel looks OK
* File list of curl looks OK

Needs work:
* Missing SMP flags. If it doesn't build with it, please add a comment
  (wiki: PackagingGuidelines#parallelmake)
* Spec file: some paths are not replaced with RPM macros
  (wiki: QAChecklist item 7)
* The %makeinstall macro should not be used
  (wiki: PackagingGuidelines#MakeInstall)
* rpmlint of curl-devel: rpmlint not clean: W: curl-devel summary-ended-with-dot Files needed for 
building applications with libcurl.
* rpmlint of curl: rpmlint not clean: W: curl one-line-command-in-%post /sbin/ldconfig.

Minor:
* Duplicate BuildRequires: pkgconfig (by libidn-devel)

Notes:
* Requires: openssl is not needed (Wiki: Extras/FullExceptionList)
* in %package devel: Requires should probably be BuildRequires
* Please use $RPM_OPT_FLAGS



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.