[Bug 225671] Merge Review: curl

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: curl


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225671





------- Additional Comments From jnovy at redhat.com  2007-02-05 09:14 EST -------
> Needs work:
> * Missing SMP flags. If it doesn't build with it, please add a comment
>   (wiki: PackagingGuidelines#parallelmake)

Fixed.

> * Spec file: some paths are not replaced with RPM macros
>   (wiki: QAChecklist item 7)

Fixed.

> * The %makeinstall macro should not be used
>   (wiki: PackagingGuidelines#MakeInstall)

cURL won't build without the %makeinstall

> * rpmlint of curl-devel: rpmlint not clean: W: curl-devel
summary-ended-with-dot Files needed for 
> building applications with libcurl.
> * rpmlint of curl: rpmlint not clean: W: curl one-line-command-in-%post
/sbin/ldconfig.

Fixed.

> Minor:
> * Duplicate BuildRequires: pkgconfig (by libidn-devel)

I don't think this is something we want to fix, as we are going to have troubles
if the libidn maintainer drops the pkgconfig dependency.

> Notes:
> * Requires: openssl is not needed (Wiki: Extras/FullExceptionList)

Fixed.

> * in %package devel: Requires should probably be BuildRequires

Nope, there should be AFAIK only Requires for the subpackages.

> * Please use $RPM_OPT_FLAGS

Fixed.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.