[Bug 225244] Merge Review: amtu

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: amtu


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225244


kevin at tummy.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|kevin at tummy.com             |sgrubb at redhat.com
               Flag|fedora-review?              |fedora-review-




------- Additional Comments From kevin at tummy.com  2007-02-03 14:31 EST -------
OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name.
OK - Spec has consistant macro usage.
OK - Meets Packaging Guidelines.
OK - License (CPL)
OK - License field in spec matches
OK - License file included in package
OK - Spec in American English
OK - Spec is legible.
See below - Sources match upstream md5sum:

OK - BuildRequires correct
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
See below - Package has correct buildroot
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.

OK - Package compiles and builds on at least one arch.
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
OK - Package owns all the directories it creates.
See below - No rpmlint output.
See below - final provides and requires are sane:

SHOULD Items:

OK - Should build in mock.
OK - Should build on all supported archs
OK - Should have dist tag
See below - Should package latest version
0 outstanding bugs - check for outstanding bugs on package.

Issues:

1. Where is the upstream for this version?
http://sourceforge.net/project/showfiles.php?group_id=130497
seems to have version 1.0.2, where is 1.0.4 available?

2. our pal rpmlint says:

rpmlint on ./amtu-debuginfo-1.0.4-4.fc7.i386.rpm
W: amtu-debuginfo invalid-license Common Public License

This seems to be ignoreable... the CPL is a ok license.

W: amtu-debuginfo no-url-tag

Should add URL tag, perhaps:
http://sourceforge.net/project/showfiles.php?group_id=130497

rpmlint on ./amtu-1.0.4-4.fc7.src.rpm
W: amtu invalid-license Common Public License
W: amtu no-url-tag
W: amtu setup-not-quiet

Setup should have -q on it?
E: amtu configure-without-libdir-spec

Why aren't you using %configure?

W: amtu macro-in-%changelog clean
W: amtu macro-in-%changelog files

Those should be %%clean and %%files

E: amtu non-readable /usr/bin/amtu 0750
E: amtu non-standard-executable-perm /usr/bin/amtu 0750

Why is this 750?

W: amtu wrong-file-end-of-line-encoding /usr/share/doc/amtu-1.0.4/AMTUHowTo.txt

This should be fixed to not have doc line endings...

3. Why the compiler setting stuff in build?
Also, can you use %{smp_mflags} ?

4. Is the "Requires: audit >= 1.1.2" required? Looks like rpm picks up the
libaudit requirement...

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.