[Bug 225244] Merge Review: amtu

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: amtu


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225244





------- Additional Comments From sgrubb at redhat.com  2007-02-04 09:03 EST -------
1. Where is the upstream for this version?

IBM has it.

2. our pal rpmlint says:

>Should add URL tag, perhaps:
>http://sourceforge.net/project/showfiles.php?group_id=130497

I don't know where IBM distributes it from. I work directly with them on CC
evals and the tarball is emailed to me.

>Setup should have -q on it?

I suppose it could. Doesn't hurt anything either way.

>Why aren't you using %configure?

In my experience, some packages will not build with %configure. We might be able
to change it.

>W: amtu macro-in-%changelog clean

will change

>W: amtu macro-in-%changelog files

will change

>E: amtu non-readable /usr/bin/amtu 0750
>E: amtu non-standard-executable-perm /usr/bin/amtu 0750
>
>Why is this 750?

Because it needs to be. It requires privileges to run. If it were available to
accounts that could run it and fail, the audit requirements are higher.

>W: amtu wrong-file-end-of-line-encoding /usr/share/doc/amtu-1.0.4/AMTUHowTo.txt
>
>This should be fixed to not have doc line endings...

Attach a patch please.

>3. Why the compiler setting stuff in build?

Because it requires special handling between the arches and to follow the
guidelines issued internally to Red Hat. If you have redhat-rpm-config
installed, there are build flags that get picked up this way.

>Also, can you use %{smp_mflags} ?

why?

>4. Is the "Requires: audit >= 1.1.2" required? Looks like rpm picks up the
>libaudit requirement...

Yes, but there are different versions of audit and that one has the api that we
want.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.