[Bug 225641] Merge Review: chkconfig

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: chkconfig


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225641


ruben at rubenkerkhof.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|ruben at rubenkerkhof.com      |notting at redhat.com
                 CC|                            |ruben at rubenkerkhof.com
               Flag|fedora-review?              |fedora-review-




------- Additional Comments From ruben at rubenkerkhof.com  2007-02-03 16:49 EST -------
* RPM name is OK
* This is the latest version
* Builds fine in mock
* File list of chkconfig looks OK
* File list of ntsysv looks OK

Needs work:
* BuildRoot should be %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
  (wiki: PackagingGuidelines#BuildRoot)
* Missing SMP flags. If it doesn't build with it, please add a comment
  (wiki: PackagingGuidelines#parallelmake)
* Spec file: some paths are not replaced with RPM macros
  (wiki: QAChecklist item 7)

Minor:
* Duplicate BuildRequires: newt (by newt-devel)

Notes:
* Please use {?dist} in the Release tag
* I'm not sure what BuildPrereq does, but can you use BuildReq?
* Can you use make DESTDIR instead of make instroot
* Replace /etc with %{_sysconfdir} and /usr/sbin with %{_sbindir}

rpmlint output is not silent:

[ruben at odin chkconfig]$ cat rpmlint-srpm.log 
W: chkconfig no-url-tag
W: chkconfig buildprereq-use newt newt-devel gettext
W: chkconfig macro-in-%changelog pre
W: chkconfig macro-in-%changelog pre


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.