[Bug 225641] Merge Review: chkconfig

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: chkconfig


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225641





------- Additional Comments From notting at redhat.com  2007-02-03 23:49 EST -------
(In reply to comment #1)
> Needs work:
> * BuildRoot should be
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

Fixed upstream.

>   (wiki: PackagingGuidelines#BuildRoot)
> * Missing SMP flags. If it doesn't build with it, please add a comment

Sure! Although, there's only 4 source files. Can't speed it up
*that* much. :)

>   (wiki: PackagingGuidelines#parallelmake)
> * Spec file: some paths are not replaced with RPM macros

/etc, /usr/sbin are compiled in. Having it as a macro can't really help.

> Minor:
> * Duplicate BuildRequires: newt (by newt-devel)

Fixed.

> Notes:
> * Please use {?dist} in the Release tag

It's not really ever rebased between releases.

> * I'm not sure what BuildPrereq does, but can you use BuildReq?

It's a synonym. Switched, though.

> * Can you use make DESTDIR instead of make instroot

Fixed upstream.

> * Replace /etc with %{_sysconfdir} and /usr/sbin with %{_sbindir}

See above.

> [ruben at odin chkconfig]$ cat rpmlint-srpm.log 
> W: chkconfig no-url-tag

No URL to have.

> W: chkconfig buildprereq-use newt newt-devel gettext
> W: chkconfig macro-in-%changelog pre
> W: chkconfig macro-in-%changelog pre

Fixed.

Uploaded spec @ http://people.redhat.com/notting/review/



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.