[Bug 225641] Merge Review: chkconfig

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: chkconfig


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225641





------- Additional Comments From ruben at rubenkerkhof.com  2007-02-04 06:27 EST -------
Hi Bill,

I just tried a mock build from the spec at http://people.redhat.com/notting/review/, and it failed.

+ make DESTDIR=/var/tmp/chkconfig-1.3.32-1-root-mockbuild MANDIR=/usr/share/man install
[ -d //sbin ] || mkdir -p //sbin
[ -d //usr/sbin ] || mkdir -p //usr/sbin
[ -d //usr/share/man ] || mkdir -p //usr/share/man
[ -d //usr/share/man/man8 ] || mkdir -p //usr/share/man/man8
[ -d //usr/share/man/man5 ] || mkdir -p //usr/share/man/man5
[ -d //var/lib/alternatives ] || mkdir -p -m 755 //var/lib/alternatives
[ -d //etc/alternatives ] || mkdir -p -m 755 //etc/alternatives
install -m 755 chkconfig //sbin/chkconfig
install: cannot remove `//sbin/chkconfig': Permission denied
make: *** [install] Error 1
error: Bad exit status from /var/tmp/rpm-tmp.20880 (%install)

So we can either stick with instroot, or replace instroot with DESTDIR in the Makefile.
One issue is that DESTDIR is not passed through to the Makefile in the po subdirectory.
Please let me know what you think.

Ok, in reply to comment #2:
> /etc, /usr/sbin are compiled in. Having it as a macro can't really help.

They're defined as variables in the makefile.
You could use make DESTDIR=$RPM_BUILDROOT ALTDIR=%{_sysconfdir}/alternatives etc.. but I'm not 
sure it's worth the effort.  Unless we're planning on moving /etc to another directory in FC-8 ;-)

> It's not really ever rebased between releases.

Ok

> No URL to have.

Ok, the URL can be added after the merge, when the tarball is available from the Fedora repo.

Thanks,

Ruben



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.