[Bug 225244] Merge Review: amtu

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: amtu


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225244





------- Additional Comments From kevin at tummy.com  2007-02-04 10:20 EST -------
In reply to comment #3: 

>I don't know where IBM distributes it from. I work directly with them on CC
>evals and the tarball is emailed to me.

Could you perhaps ping them to update the sourceforge site with the latest?
Then it would be easy to check against upstream. 

>>Setup should have -q on it?
>
>I suppose it could. Doesn't hurt anything either way.

True, just more in line with all the other packages... 

>>Why aren't you using %configure?
>
>In my experience, some packages will not build with %configure. We might be
>able to change it.

Can you try and do so?

>>Why is this 750?
>
>Because it needs to be. It requires privileges to run. If it were available to
>accounts that could run it and fail, the audit requirements are higher.

Sounds reasonable. 

>>This should be fixed to not have doc line endings...
>
>Attach a patch please.

You can do it in the spec... just add: 

%{__sed} -i 's/\r//' AMTUHowTo.txt

>>3. Why the compiler setting stuff in build?
>
>Because it requires special handling between the arches and to follow the
>guidelines issued internally to Red Hat. If you have redhat-rpm-config
>installed, there are build flags that get picked up this way.

It seems like if that was the case you would want to just override the
RPM_OPT_FLAGS in those places (ie, in rpm or macro files). 

>>Also, can you use %{smp_mflags} ?
>
>why?

Indeed this is a small package and it might not be worth it, but if it works, 
why not? Would save a bit of build time. 

Agreed on everything else... 

When you have updated rawhide/cvs, let me know and reassign me on this bug, 
and I will be happy to check over changes. 


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.