[Bug 226188] Merge Review: ncurses

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: ncurses


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226188


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|tibbs at math.uh.edu           |mlichvar at redhat.com
               Flag|fedora-review?              |fedora-review-




------- Additional Comments From tibbs at math.uh.edu  2007-02-04 13:34 EST -------
I fear this will be mildly difficult, as the ncurses build process seems mildly complicated and I can't really tell if it all actually needs to be that way, so I'll need help from you to comprehend what's going on.

First, let's look at rpmlint output:

E: ncurses tag-not-utf8 %changelog
E: ncurses-debuginfo tag-not-utf8 %changelog
E: ncurses-devel tag-not-utf8 %changelog
E: ncurses tag-not-utf8 %changelog
E: ncurses non-utf8-spec-file ncurses.spec
   These are due to bero's name in the changelog and should go away with a bit
   of editing or a pass through iconv.

W: ncurses invalid-license distributable
W: ncurses-debuginfo invalid-license distributable
W: ncurses-devel invalid-license distributable
W: ncurses invalid-license distributable
   The license is actually BSD, and the license tag should be changed to
   match.

E: ncurses-devel obsolete-not-provided ncurses-c++-devel
W: ncurses unversioned-explicit-obsoletes ncurses-c++-devel
   These should just go away; the last time that package was shipped was RH9.

E: ncurses-devel script-without-shebang /usr/share/doc/ncurses-devel-5.6/test/savescreen.c
E: ncurses-devel script-without-shebang /usr/share/doc/ncurses-devel-5.6/test/demo_panels.c
W: ncurses-devel doc-file-dependency /usr/share/doc/ncurses-devel-5.6/test/tracemunch perl(strict)
W: ncurses-devel doc-file-dependency /usr/share/doc/ncurses-devel-5.6/test/tracemunch /usr/bin/perl
   None of these should be executable.  I suppose there's plenty of value in
   packaging these because it's not really possible to run the tests at build
   time, but the bottom line is that documentation should not be executable.

E: ncurses hardcoded-library-path in /lib
   This is specifying the location of the terminfo directory; my understanding
   is that it needs to be in /lib regardless of the architecture.

W: ncurses rpm-buildroot-usage %build --with-install-prefix=$RPM_BUILD_ROOT \\\
   This I am not conmpletely sure of.  The intent is to make sure you don't
   mess with the buildroot in a way that breaks short-circuiting (because
   nothing should go into the buildroot until %install).  But this is just
   defining something that sets up the install location and so it should be
   OK, but I'd like to know before approving this that the usual
   "make DESTDIR=... install" or even %makeinstall doesn't work for this
   package.

Those are the only issues of note, and should be pretty easy to fix up.

Review:
* source files match upstream:
   f9cac2b31683a37d65bc37119599752198a0691e462d0d1a252cf9815f5724d5
   ncurses-5.6.tar.gz
* package meets naming and versioning guidelines:
   Looks like a post-release snapshot and is named according to upstream's
   policy.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
X license field says "distributable" but is really BSD.
* license is open source-compatible.  License text included in package.
O latest version is not being packaged:
    I think a new rollup came out yesterday morning, but it's certainly not a
    blocker.
* BuildRequires are proper.
* compiler flags are appropriate.
* %clean is present.
* %makeinstall is not used.
* package builds in mock.
* debuginfo package looks complete.
X rpmlint is silent.
X final provides and requires are sane:
  There are a couple of errant Perl requirements in the -devel package that
  come from executable documentation.
  ncurses-5.6-2.20070120.fc7.i386.rpm:
   libform.so.5
   libformw.so.5
   libmenu.so.5
   libmenuw.so.5
   libncurses.so.5
   libncursesw.so.5
   libpanel.so.5
   libpanelw.so.5
   libtic.so.5
   ncurses = 5.6-2.20070120.fc7
  =
   /sbin/ldconfig
   libform.so.5
   libformw.so.5
   libmenu.so.5
   libmenuw.so.5
   libncurses.so.5
   libncursesw.so.5
   libpanel.so.5
   libpanelw.so.5
   libtic.so.5

  ncurses-devel-5.6-2.20070120.fc7.i386.rpm:
   ncurses-devel = 5.6-2.20070120.fc7
  =
   /bin/sh
X  /usr/bin/perl
   libform.so.5
   libformw.so.5
   libmenu.so.5
   libmenuw.so.5
   libncurses.so.5
   libncursesw.so.5
   libpanel.so.5
   libpanelw.so.5
   libtic.so.5
   ncurses = 5.6-2.20070120.fc7
X  perl(strict)

* %check is not present; there's a test suite upstream, but it's interactive
  and so not runnable at build time.
* shared libraries are present and ldconfig is called properly.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
X file permissions are appropriate (executable documentation)
* scriptlets are OK (ldconfig)
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* headers are in the -devel package.
* no pkgconfig files.
   There are old-style *-config files in /usr/bin, and they are packaged
   properly.
* no libtool .la droppings.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.