[Bug 226188] Merge Review: ncurses

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: ncurses


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226188





------- Additional Comments From mlichvar at redhat.com  2007-02-05 11:36 EST -------
Thanks for the review.

> W: ncurses invalid-license distributable
>    The license is actually BSD, and the license tag should be changed to
>    match.

Or even better MIT license, is that correct?

> W: ncurses rpm-buildroot-usage %build --with-install-prefix=$RPM_BUILD_ROOT \\\
>    This I am not conmpletely sure of.  The intent is to make sure you don't
>    mess with the buildroot in a way that breaks short-circuiting (because
>    nothing should go into the buildroot until %install).  But this is just
>    defining something that sets up the install location and so it should be
>    OK, but I'd like to know before approving this that the usual
>    "make DESTDIR=... install" or even %makeinstall doesn't work for this
>    package.

The configure option just sets DESTDIR value in Makefiles, it is the same as
installing with DESTDIR=..., but less typing. Should I remove it?

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.