[Bug 226998] Review Request: gemdropx - Falling blocks puzzlegame

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gemdropx - Falling blocks puzzlegame


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226998





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-02-07 12:45 EST -------
Well,

* BuildRequires
  - Mockbuild fails on FC7 i386 (needs desktop-file-utils)

* Documentation
  - Please add other "README" files 

* Timestamps
  - keep timestamps on image files and etc, i.e. use "cp -p"
    or "install -p"

* Desktop file entry
-----------------------------------------------------
  --add-category X-Fedora                       \
-----------------------------------------------------
  is deprecated and should be removed.

* Scriptlets
-----------------------------------------------------
if [ -x %{_bindir}/gtk-update-icon-cache ]; then
-----------------------------------------------------
  is redundant because execution of non-existing file
  simply exits with 127 and is ignored by || :

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.