[Bug 228272] Review Request: amarokFS - Simple, nice looking full screen front-end for Amarok

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: amarokFS - Simple, nice looking full screen front-end for Amarok


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=228272


gauret at free.fr changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |gauret at free.fr
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From gauret at free.fr  2007-02-12 17:11 EST -------
Needs work:
* Source URLs are:
http://www.kde-apps.org/CONTENT/content-files/52641-amarokFS-qt3-0.4.2.tar.gz
* An icon is installed directly under %_datadir/icons
(/usr/share/icons/amarokFS.png). Please use the hicolor directory and its
sub-directories, as required by the spec (al least a 48x48 icon)
* Scriptlets: missing "gtk-update-icon-cache" in %post and %postun (wiki:
ScriptletSnippets)

Minor:
* QT environment variable are not sourced
* Desktop file: the Categories tag should not contain Application any more
  (wiki: PackagingGuidelines#desktop)
* The package should contain the text of the license, please ask the author to
include it in the tarball. It's not a blocker for the package, but it would be
better.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.