[Bug 228272] Review Request: amarokFS - Simple, nice looking full screen front-end for Amarok

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: amarokFS - Simple, nice looking full screen front-end for Amarok


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=228272





------- Additional Comments From faucamp at csir.co.za  2007-02-13 08:53 EST -------
Thanks for the feedback!

New build:
Spec URL: http://www.snoekie.com/rpm/amarokFS.spec
SRPM URL: http://www.snoekie.com/rpm/amarokFS-0.4.2-2.src.rpm

Changes:
- Added BuildRequires: desktop-file-utils
- Fixed source URLs
- Removed "Application" from .desktop file's "Categories" tag
- Install application icon to correct location
- Added KDE/GTK icon cache update scriptlets
- Cleaned up the application's qmake file a bit


(In reply to comment #1)
> Needs work:
> * QT environment variable are not sourced

I am not following you here - the package is being built using qmake; AFAIK the
"CONFIG += qt" line in the qmake project file takes care of this?
I have cleaned up the .pro file accordingly to make it more clear, though. 

> * The package should contain the text of the license, please ask the author to
> include it in the tarball. It's not a blocker for the package, but it would be
> better.

I agree. The developer seems to be away on holiday at the moment, but I will
mail him about this; I also plan on submitting some of the patches/bugfixes I
added to this application once the package is approved.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.