[Bug 226496] Merge Review: tn5250

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: tn5250


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226496





------- Additional Comments From pertusus at free.fr  2007-02-13 07:40 EST -------
(In reply to comment #2)
> all except suggestions 2 and 4 fixed in tn5250-0.17.3-8.fc7
> - failed scripts often lead to duplicate packages in the rpmdb, I'd like to
> avoid that

You are right, and I agree with you. I didn't targeted the rm -f in 
scriptlets, but in %install:
rm -f $RPM_BUILD_ROOT/%{_libdir}/lib5250.la

> - %patch -b can lead to rpms containing backup files if you aren't careful. It
> happened in the past and will happen again. 
> I'd suggest the opposite: remove all -b flags and add them only when you need
> them  for gendiff.

Ok, as you like.



I haven't seen the changes, so I guess it takes time for changes in 
internal cvs to propagate.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.