[Bug 226496] Merge Review: tn5250

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: tn5250


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226496





------- Additional Comments From pertusus at free.fr  2007-02-13 09:44 EST -------
There is still a missing
Requires(post): /sbin/ldconfig

The Application; and X-Red-Hat-Base categories shouldn't be added, 
in my opinion. And the Network category would better be in the
.desktop file instead of added in the spec file.

In the xt5250.desktop file there shouldn't be any Mimetype entry.

If I recall well the guidelines, --vendor should be fedora.

The autotools are rerun during the build, certainly because the patching
of autotool files makes some files newer that generated files.
You can fix that by touching generated files, or by keeping the 
original timestamps when patching (that can be achieved with cp -p
and touch -r).

I think it would be better if tn5250-48x48.{png,xpm} were called 
tn5250.{png,xpm} in /usr/share/icons/hicolor/48x48/apps/, and
tn5250-62x48.{png,xpm} were put in /usr/share/icons/hicolor/64x64/apps and
also called tn5250.{png,xpm}.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.