[Bug 229826] Review Request: Chmsee - a GTK2 CHM viewer based on chmlib and gecko

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Chmsee - a GTK2 CHM viewer based on chmlib and gecko


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=229826





------- Additional Comments From bbbush.yuan at gmail.com  2007-02-28 09:26 EST -------
(In reply to comment #24)
> ------------------------------------------------
> BuildRequires: firefox-devel = 2.0.0.1
> Requires: firefox = 2.0.0.1
> ------------------------------------------------

added.

(In reply to comment #25)
> 
> This is not for the fedora package but for upstream. There is no 
> problem for us to disable smp_mflags. However I had a look, and a
> possibility is that chmsee_LDFLAGS is used incorrectly to specify
> library link, it should only be for linker options, chmsee_LDADD
> is for link. So in my opinion, it should be along:
> 
> chmsee_LDFLAGS = -R$(GECKO_HOME) \
>         $(AM_LDFLAGS)
> 
> chmsee_LDADD = \
>         libcppwrapper.la \
>         @CHMSEE_LIBS@ \
>         @CHMLIB_LIBS@ \
>         @MD5_LIBS@ \
>         $(GECKO_LIBS) \
>         $(GECKO_EXTRA_LIBS)
> 

Thanks very much!

> 
> 
> > icon scriptlet updated.
> 
> Still missing in %postun
> 

:D

> Also I think the use of the gnochm icon for mimetype deserves a 
> comment. It is in changelog, but it seems to me that a comment
> near the Source1 or near the install calls in %install should be
> there too.

added.


Spec URL: ftp://ftp.fedora.cn/pub/fedora-cn/in-review/chmsee.spec
SRPM URL: ftp://ftp.fedora.cn/pub/fedora-cn/in-review/chmsee-1.0.0-0.10.beta.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.