[Bug 229826] Review Request: Chmsee - a GTK2 CHM viewer based on chmlib and gecko

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Chmsee - a GTK2 CHM viewer based on chmlib and gecko


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=229826





------- Additional Comments From pertusus at free.fr  2007-02-28 18:51 EST -------
* rpmlint (ignorable, but you could want to fix it):
W: chmsee mixed-use-of-spaces-and-tabs (spaces: line 8, tab: line 1)
* free software license, included
* follow guidelines
* scriptlets are right
* sane provides
* match upstream:
b18df276ff8050668ff3da163efe147c  chmsee-1.0.0-beta.tar.gz
* %files section right
* .desktop right

APPROVED

You seem to be quite active in the fedora community, and I'll
sponsor you. I think that you learned a lot in this review and
others, but I am not completely sure that you know the guidelines
and procedures enough already to formally approve packages; in 
little time you will be experienced enough, but maybe for your 
first reviews you could do the whole review but ask for another 
look before formally approving. Feel also free to disregard my 
advice...


- first note:
there is a potential directory owning issue since
/usr/share/icons/gnome/
/usr/share/icons/hicolor/
and some directories below may be unowned. However this is an issue
that should be fixed with a freedesktop filesystem package or the
like, so I let it be. I would suggest owning those directories, though.

- 2nd note:
I'll try to remember to watch out changes in the gnochm icon.

- 3rd note, there is linking against libraries that are not useful:
$ ldd -u -r /usr/bin/chmsee 
Unused direct dependencies:

        /lib/librt.so.1
        /usr/lib/libatk-1.0.so.0
        /usr/lib/libpng12.so.0
        /lib/libm.so.6
        /usr/lib/libpangocairo-1.0.so.0
        /usr/lib/libcairo.so.2
        /lib/libgmodule-2.0.so.0
        /lib/libssl.so.6
        /usr/lib/libplds4.so
        /usr/lib/libplc4.so
        /usr/lib/libnspr4.so
        /lib/libdl.so.2

This is very common, and not a big deal, but this could force 
unneeded rebuilds when the sonames change and cause rpm/yum/... 
to be less efficient. In general the fix is to use Private 
rightly in the .pc files of those libs, and sometimes there
is also things to do in the package to avoid over linking.
This is not a must fix at all you can completely ignore that
issue.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.