[Bug 222594] Review Request: seedit: SELinux Policy Editor

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: seedit: SELinux Policy Editor


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222594





------- Additional Comments From lxtnow at gmail.com  2007-01-18 07:26 EST -------
(In reply to comment #4)

> - MUSTFIX: Directory /usr/lib/python2.4/site-packages/seedit is unowned.
> The seedit package must known this directory.
s/known/own/

more info:
your directory /usr/lib/python2.4/site-packages/seedit
should look like this --> %{python_sitelib}/%{name}/
where your defined python_sitelib must set above with something like this:
%define python_sitelib %(%{__python} -c 'from distutils import sysconfig; print
sysconfig.get_python_lib()')


> >#policy,gui subpackages are build only when arch is "noarch" >--> why don't you
> set them to noarch in spec file ?
> 
> I wanted to make noarch.rpm not i386.rpm for doc and gui subpackage, 
> but it seems that such sub packages are usually build as i386.rpm in fedora.
>Right, this is impossible. All packages being built from a common src.rpm share
>the same arch.

i meant to set subpakage section to "buildarch:     noarch"

more comment:

vendor option in desktop-file-install should set to vendor ""
set it to fedora is not required any more.

in %post policy:
touch %{_datadir}/share/seedit/sepolicy/need-init 
--> %{_datadir}/%{name}/sepolicy/need-init
same thing for the other below.

%doc should be place just after %defattr macros and on the same line.

missing argument:
%files -f %{name}.lang
see Handling Locale Files section in
http://fedoraproject.org/wiki/Packaging/Guidelines



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.