[Bug 222594] Review Request: seedit: SELinux Policy Editor

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: seedit: SELinux Policy Editor


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222594





------- Additional Comments From ynakam at hitachisoft.jp  2007-01-18 22:36 EST -------
(In reply to comment #5)
>- MUSTFIX: Package doesn't honor RPM_OPT_FLAGS:
>...
>gcc -c -Wall -O2 -g -DDEBUG=1 -I../include  -I/usr/include/selinux lex.yy.c
>..
Fixed. Modified spec file and Makefiles.

>- SHOULDFIX: Incorrect include directory -I/usr/include
>...
>cc -Werror -Wall -W -I/usr/include -D_FILE_OFFSET_BITS=64 -D_GNU_SOURCE
>-I../include -I/usr/include/selinux -Dfc6   -c -o seedit-restorecon.o 
>...
>Passing -I/usr/include is a mistake. You should never pass -I/usr/include.
Fixed.

>- MUSTFIX: Directory /usr/lib/python2.4/site-packages/seedit is unowned.
>The seedit package must own this directory.
Fixed.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.