[Bug 222521] Review Request: IceWM - Lightweight Window Manager.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: IceWM -  Lightweight Window Manager.


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222521





------- Additional Comments From pertusus at free.fr  2007-01-18 20:17 EST -------
There is a missing requires for:
/usr/share/pixmaps/gnome-terminal.png
but maybe there could be a more neutral default? Also
from reading the docs it seems that a png in /usr/share/pixmaps/
is used automatically, it would be better to omit the path, then.

Regarding the -gnome subpackage, the BuildRequires should be
in the main package. The main package is the only source package, 
subpackages are binary packages.

Source1 should be with full url.

Your %attr line for icewm-xdg-menu.* isn't completly right, since
the files end up being owned by the user doing the rpm build.
I think it should be
%attr(0755,root,root) %{_bindir}/icewm-xdg-menu.*

regarding man pages and globs, you misunderstood my comment 
(which wasn't clear...). A line of code is better than a long
explanation, so I think the best would be, in %install:

install -p -m 644 doc/icewm.1.man $RPM_BUILD_ROOT/%{_mandir}/man1/icewm.1

And in %files:

%{_mandir}/man1/icewm.1*


Please remove the dot at the end of the -gnome subpackage summary.

The /etc is hardcoded for the System configuration directory. To have
instead %{_sysconfdir} used, you should add to %configure:

   --with-cfgdir=%{_sysconfdir}/icewm



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.