[Bug 222338] Review Request: initng-conf-gtk - InitNG configuration and control utility

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: initng-conf-gtk - InitNG configuration and control utility


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222338





------- Additional Comments From ynakam at hitachisoft.jp  2007-01-29 23:17 EST -------
I am not sponsor, so it is pre-review.
I am seeking for sponsor, at Bug 222594 .
I have looked at your spec file, and have some comments.

1) %makeinstall
You can not use %makeinstall. 
http://fedoraproject.org/wiki/Packaging/Guidelines#head-fcaf3e6fcbd51194a5d0dbcfbdd2fcb7791dd002

2) More macros
You can replace initng-conf-gtk with %{name}.

3) desktop-file-install --vendor fedora --delete-original \
  --dir $RPM_BUILD_ROOT%{_datadir}/applications \
  $RPM_BUILD_ROOT%{_datadir}/applications/initng-conf-gtk.desktop

--vendor fedora ->  --vendor "" 
You do not have to set vendor as fedora.

4) make
You have to use %{optflags} :
http://fedoraproject.org/wiki/Packaging/Guidelines#head-8b14098227aebff1cf6188939e9d0877295ac448

and also %{?_smp_mflags} :
http://fedoraproject.org/wiki/Packaging/Guidelines#head-525c7d76890cb22df33b759c65c35c82bf434d2e

5) Timestamp
I built SRPM, and found -p is not used for cp and install.
http://fedoraproject.org/wiki/Packaging/Guidelines#head-0239576e441f9ef53d175c4aec8c12868dffb5ab



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.