[Bug 222338] Review Request: initng-conf-gtk - InitNG configuration and control utility

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: initng-conf-gtk - InitNG configuration and control utility


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222338





------- Additional Comments From dm at mensa.se  2007-01-30 02:47 EST -------
(In reply to comment #2)
> 1) %makeinstall
> You can not use %makeinstall. 

Ok.

> 2) More macros
> You can replace initng-conf-gtk with %{name}.

Yep.

> 3) desktop-file-install --vendor fedora --delete-original \
>   --dir $RPM_BUILD_ROOT%{_datadir}/applications \
>   $RPM_BUILD_ROOT%{_datadir}/applications/initng-conf-gtk.desktop
> 
> --vendor fedora ->  --vendor "" 
> You do not have to set vendor as fedora.

Ah. Looks like I mixed up vendor_id and vendor...

> 4) make
> You have to use %{optflags} :
>
http://fedoraproject.org/wiki/Packaging/Guidelines#head-8b14098227aebff1cf6188939e9d0877295ac448

This fails with the following:

+ make -j2 -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions
-fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic
make: invalid option -- O
make: invalid option -- 2
make: invalid option -- g
make: unrecognized option `--param=ssp-buffer-size=4'
make: invalid option -- 6
make: invalid option -- 4
make: invalid option -- u
make: invalid option -- =
make: invalid option -- g
make: invalid option -- c

Anyone knows what I'm doing wrong?

> and also %{?_smp_mflags} :
>
http://fedoraproject.org/wiki/Packaging/Guidelines#head-525c7d76890cb22df33b759c65c35c82bf434d2e

Yep.

> 5) Timestamp
> I built SRPM, and found -p is not used for cp and install.
>
http://fedoraproject.org/wiki/Packaging/Guidelines#head-0239576e441f9ef53d175c4aec8c12868dffb5ab

Now you lost me. I can't seem to find any cp or install commands in my spec file?


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.