[Bug 241075] Review Request: redet - Regular expression development and execution tool

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: redet - Regular expression development and execution tool


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241075





------- Additional Comments From tibbs at math.uh.edu  2007-05-31 22:36 EST -------
Indeed, this builds fine and rpmlint is nice and quiet.

However, I'm not sure why you gzip the manpage and then patch up the Makefile so
that it will install the compressed version.  rpmbuild will compress the
manpages for you; you just have to list them in your %files section like:
 %{_mandir}/man1/redet.1*
Of course, it seems that you need to patch the Makefile for other reasons, which
is fine.  I guess you could just ignore the Makefile and just install the two
files by hand; that would be up to you.

Finally, there's no .desktop file, so this package won't show up in the desktop
menus.  According to the guidelines, every graphical application needs to have a
.desktop file.

* source files match upstream:
   17ca181886030ecba8a1fb7d8906016dd8754f345a22fc3f56817683e93f5342
   redet-8.22.tar.bz2
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
* BuildRequires are proper (none).
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
* rpmlint is silent.
* final provides and requires are sane:
   redet = 8.22-1.fc7
  =
   /bin/sh
   iwidgets
* %check is not present; no test suite upstream.  Seems to run fine for me, 
  although I didn't test extensively.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is already in a separate package.
X GUI app, but no .desktop file.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.