[Bug 241075] Review Request: redet - Regular expression development and execution tool

bugzilla at redhat.com bugzilla at redhat.com
Fri Jun 1 03:40:11 UTC 2007


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: redet - Regular expression development and execution tool


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241075





------- Additional Comments From dev at nigelj.com  2007-05-31 23:40 EST -------
(In reply to comment #1)
> Indeed, this builds fine and rpmlint is nice and quiet.
> 
> However, I'm not sure why you gzip the manpage and then patch up the Makefile so
> that it will install the compressed version.  rpmbuild will compress the
> manpages for you; you just have to list them in your %files section like:
>  %{_mandir}/man1/redet.1*
> Of course, it seems that you need to patch the Makefile for other reasons, which
> is fine.  I guess you could just ignore the Makefile and just install the two
> files by hand; that would be up to you.
I'll take a look tonight, regarding this and fix it
> 
> Finally, there's no .desktop file, so this package won't show up in the desktop
> menus.  According to the guidelines, every graphical application needs to have a
> .desktop file.
Another DOH moment, will be fixed when I get home in a few hours.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list