[Bug 207896] Review Request: astyle - Source code formatter

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: astyle - Source code formatter


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=207896





------- Additional Comments From rc040203 at freenet.de  2007-06-18 08:12 EST -------
(In reply to comment #15)
> > General Review -->
> >Well, If you want to do the review of this style, please make
> >the summary of the review so that everyone (including submitter) can
> >read your review easily.
> 
>     Hmmm... I thought I was being very thorough in my review.  I followed every
> aspect of the review process to the "T," but from now on will not post
> everything at once.
Let me put it this way: I find this style of reviews WAY too verbose to be
useful. Submitters and reviewers are drowning in irrelevant (and partially
bogus) comments.

I for one only see 2 remaining issues:
- GPL -> LGPL
- Bogus permissions on source files.
E: astyle-debuginfo script-without-shebang /usr/src/debug/astyle/src/astyle_main.cpp
W: astyle-debuginfo spurious-executable-perm /usr/src/debug/astyle/src/astyle.h
E: astyle-debuginfo script-without-shebang /usr/src/debug/astyle/src/ASEnhancer.cpp
E: astyle-debuginfo script-without-shebang /usr/src/debug/astyle/src/ASResource.cpp
E: astyle-debuginfo script-without-shebang /usr/src/debug/astyle/src/ASFormatter.cpp
E: astyle-debuginfo script-without-shebang
/usr/src/debug/astyle/src/ASBeautifier.cpp

=> Add chmod -x src/*
to %prep

All the rest is stylishness, not fixing anything.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.