[Bug 207896] Review Request: astyle - Source code formatter

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: astyle - Source code formatter


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=207896





------- Additional Comments From gnome at dux-linux.org  2007-06-18 08:46 EST -------
(In reply to comment #16)
> (In reply to comment #15)
> > > General Review -->
> > >Well, If you want to do the review of this style, please make
> > >the summary of the review so that everyone (including submitter) can
> > >read your review easily.
> > 
> >     Hmmm... I thought I was being very thorough in my review.  I followed every
> > aspect of the review process to the "T," but from now on will not post
> > everything at once.
> Let me put it this way: I find this style of reviews WAY too verbose to be
> useful. Submitters and reviewers are drowning in irrelevant (and partially
> bogus) comments.

    I'm learning and appreciate the critique.  In the future I will try to be
more specific, and instead of listing out all of the checks I did, only list the
ones that need changing; is that the style you are hinting at?  :-)

> I for one only see 2 remaining issues:
> - GPL -> LGPL

     Check.

> - Bogus permissions on source files.
> E: astyle-debuginfo script-without-shebang
/usr/src/debug/astyle/src/astyle_main.cpp
> W: astyle-debuginfo spurious-executable-perm /usr/src/debug/astyle/src/astyle.h
> E: astyle-debuginfo script-without-shebang
/usr/src/debug/astyle/src/ASEnhancer.cpp
> E: astyle-debuginfo script-without-shebang
/usr/src/debug/astyle/src/ASResource.cpp
> E: astyle-debuginfo script-without-shebang
/usr/src/debug/astyle/src/ASFormatter.cpp
> E: astyle-debuginfo script-without-shebang
> /usr/src/debug/astyle/src/ASBeautifier.cpp


      Again, I'm not getting this with rpmlint.  Can you let me know what
version of rpmlint you have please? and what version of Fedora/RHEL you're using
to build?  Thanks.

> => Add chmod -x src/*
> to %prep

      Check.
 
> All the rest is stylishness, not fixing anything.

    Ok.  :-)  Some of the points were raised for personal edification.  :-)  I
will ask those in a different forum instead of through this review.  The reason
I asked them here in the first place was so everyone on this list could learn too.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.