[Bug 234122] Review Request: pygtkglext - Python bindings for GtkGLExt

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pygtkglext - Python bindings for GtkGLExt


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234122





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-03-29 14:57 EST -------
Well, for 1.1.0-1

* %makeinstall
-------------------------------------
# Note: make install PREFIX=$RPM_BUILD_ROOT doesnot work :(
-------------------------------------
  - Perhaps you want to use the following?
-------------------------------------
make install DESTDIR=$RPM_BUILD_ROOT INSTALL="%{__install} -p"
-------------------------------------
    The above works for me. And INSTALL option should be
    added to keep timestamps on python scripts installed.

* Documentation
-------------------------------------
sed -i 's/\r//g' README.win32
-------------------------------------
  - Simply remove this line. README._win32_ should
    not be for linux.

* %files
  - By the way, why does file entry has the same line?
    (perhaps you just did copy & paste)

* libtool archives
  - Perhaps .la files should be removed.

* Executable permission vs shebang
-------------------------------------
chmod +x $RPM_BUILD_ROOT%{python_sitearch}/gtk-2.0/gtk/gtkgl/apputils.py
-------------------------------------
  - Again please check if this is correct

* Requires
-------------------------------------
Requires:       gtkglext
-------------------------------------
  - Is this needed? Libraries' dependency should automatically
    pull this.

* python_sitelib vs python_sitearch
-------------------------------------
if [ %{python_sitelib} != %{python_sitearch} ]; then
<skip>
fi
-------------------------------------
  - While this should work, IMO it is better to configure
    configure says:
-------------------------------------
 19151  if test "${am_cv_python_pythondir+set}" = set; then
 19152    echo $ECHO_N "(cached) $ECHO_C" >&6
 19153  else
 19154    am_cv_python_pythondir=`$PYTHON -c "from distutils import sysconfig;
print sysconfig.get_python_lib(0,0,prefix='$PYTHON_PREFIX')" 2>/dev/null ||
 19155       echo "$PYTHON_PREFIX/lib/python$PYTHON_VERSION/site-packages"`
 19156  fi
-------------------------------------
    From my impression, this should be okay with changing to
    get_python_lib(1,0,prefix='$PYTHON_PREFIX')

* License
  - Well, the included files are GPL and LGPL, and actually this
    is licensed under LGPL (also declared on
    http://www.k-3d.org/gtkglext/Main_Page#Licensing )

* Encoding
  - The following documents are not encoded with UTF-8. Please
    fix.
--------------------------------------
<file>          <encoded by>
AUTHORS         EUC-JP
README          EUC-JP
(README.win32   SJIS)
--------------------------------------
    (Just a note: usually Japanese documents are not encoded
     with UTF-8 and normally encoded with either EUC-JP, ISO-2022-JP
     <both are for UNIX file> or SJIS <for Windows file>)

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.