[Bug 234122] Review Request: pygtkglext - Python bindings for GtkGLExt

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pygtkglext - Python bindings for GtkGLExt


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234122





------- Additional Comments From j.w.r.degoede at hhs.nl  2007-03-29 16:59 EST -------
(In reply to comment #2)
> * %files
>   - By the way, why does file entry has the same line?
>     (perhaps you just did copy & paste)
> 
Those lines are not identical (gdkgl versus gtkgl)

> * Executable permission vs shebang
> -------------------------------------
> chmod +x $RPM_BUILD_ROOT%{python_sitearch}/gtk-2.0/gtk/gtkgl/apputils.py
> -------------------------------------
>   - Again please check if this is correct
> 

Actually this file contains a main with test routines and thus can be executed
stand alone, I've added a comment about this.

> * python_sitelib vs python_sitearch
> -------------------------------------
> if [ %{python_sitelib} != %{python_sitearch} ]; then
> <skip>
> fi
> -------------------------------------
>   - While this should work, IMO it is better to configure
>     configure says:
> -------------------------------------
>  19151  if test "${am_cv_python_pythondir+set}" = set; then
>  19152    echo $ECHO_N "(cached) $ECHO_C" >&6
>  19153  else
>  19154    am_cv_python_pythondir=`$PYTHON -c "from distutils import sysconfig;
> print sysconfig.get_python_lib(0,0,prefix='$PYTHON_PREFIX')" 2>/dev/null ||
>  19155       echo "$PYTHON_PREFIX/lib/python$PYTHON_VERSION/site-packages"`
>  19156  fi
> -------------------------------------
>     From my impression, this should be okay with changing to
>     get_python_lib(1,0,prefix='$PYTHON_PREFIX')
> 

Erm the above solution gives me a headache, and as said my own (simple,
understandable) solution works fine.

All other items fixed, here is a new version:
Spec URL: http://people.atrpms.net/~hdegoede/pygtkglext.spec
SRPM URL: http://people.atrpms.net/~hdegoede/pygtkglext-1.1.0-2.fc7.src.rpm


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.