[Bug 291741] Review Request: gnome-hearts - Game of Hearts implementation for gnome

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gnome-hearts - Game of Hearts implementation for gnome


https://bugzilla.redhat.com/show_bug.cgi?id=291741





------- Additional Comments From caillon at redhat.com  2007-11-22 19:30 EST -------
Richi, hey cool.  Glad you're taking this on.  Some drive by comments if you
don't mind:

First, I'll answer your question in the specfile.  If you have something listed
as Source1, you reference it in your spec with %{SOURCE1}.  Same with Source2 =>
%{SOURCE2}.  That said, please do not ship config.guess or config.sub at all. 
All most SRPMs should really have is the specfile and the tarball.  (Plus any
source patches, but in this case you probably won't have those if you are
pulling from svn or shipping exact releases).

Back to the tarball... If you are building a tarball yourself, please make sure
that it ships with a pre-generated configure.  The builder should not have to
_ever_ run bootstrap or autoconf.  This means, run it yourself and make sure
configure is included.  ;-)

Some other comments:

your %build section is too busy (because of the bootstrap stuff... your ideal
%build will just be calling configure and then make).

Since you are installing a .desktop file, you must register it with the system
using desktop-file-install

Since you are installing langpacks, you need to make proper use of the
%find_lang macro (and properly in the header of %files)

Thanks for your work here.  Look forward to seeing it in the repo!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.