[Bug 291741] Review Request: gnome-hearts - Game of Hearts implementation for gnome

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gnome-hearts - Game of Hearts implementation for gnome


https://bugzilla.redhat.com/show_bug.cgi?id=291741





------- Additional Comments From richip at richip.dhs.org  2007-11-22 20:41 EST -------
Hey, Chris. Thanks for the feedback!

(In reply to comment #29)
> %{SOURCE2}.  That said, please do not ship config.guess or config.sub at all. 
> All most SRPMs should really have is the specfile and the tarball.  (Plus any
> source patches, but in this case you probably won't have those if you are
> pulling from svn or shipping exact releases).
> 
> Back to the tarball... If you are building a tarball yourself, please make sure
> that it ships with a pre-generated configure.  The builder should not have to
> _ever_ run bootstrap or autoconf.  This means, run it yourself and make sure
> configure is included.  ;-)
> 
> Some other comments:
> 
> your %build section is too busy (because of the bootstrap stuff... your ideal
> %build will just be calling configure and then make).

If you haven't guessed by now, the reason "configure" doesn't exist is that I'm
pulling the source from SVN. I thought of generating configure myself before
archiving the source tree, but I just assumed that going through the whole
autoconf thing was the better route as I was afraid there might be something on
my platform that was specific to it and that autoconf on the build machine would
do differently. That's 'cause I don't really know how autoconf works, ;).

> Since you are installing a .desktop file, you must register it with the system
> using desktop-file-install

I was wondering at what else I needed to do during install and uninstallation.
Unfortunately, the Packaging Guidline doesn't go too deeply into platform-,
subsystem-, or DE-specific processes. Things like "desktop-file-install" or
"export GCONF_DISABLE_MAKEFILE_SCHEMA_INSTALL=1", I only glean from examples.
(Or did I miss it in the Guidelines?)

> Since you are installing langpacks, you need to make proper use of the
> %find_lang macro (and properly in the header of %files)

Right. Sorry about that. I actually came across that guideline but only applied
it to the second package I was preparing (gpass). I'll work on it. Is that not a
check that can be added to rpmlint?

> Thanks for your work here.  Look forward to seeing it in the repo!

Me, too! It's one of my favorite card games and I get to play it on my machine.
'Twould be nice to have the multiplayer, networked version soon.

I'll make another release tonight.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.