[Bug 280751] Review Request: qmmp - Qt-based multimedia player

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: qmmp - Qt-based multimedia player


https://bugzilla.redhat.com/show_bug.cgi?id=280751





------- Additional Comments From kvolny at redhat.com  2007-09-11 04:35 EST -------
(In reply to comment #2)
> Quick initial comments:
> 1.  Drop
> Requires:       flac >= 1.1.3 jack-audio-connection-kit >= 0.102.5 libmpcdec 
>= 1.2.2
> alsa-lib taglib qt4 >= 4.2
> rpm should auto-req these without listing them explicitly.

I've already dropped dependencies on libogg etc., as suggested, but those left 
were not mentioned by rpmlint and I did not "just try" ...

> 2.  wrt desktop-file-install usage, drop
> --add-category X-Fedora --add-category X-Red-Hat-Extra
> see also:
> 
http://fedoraproject.org/wiki/Packaging/Guidelines#head-d559ee7363418a5840ce63090c608c991cd39ce6

"X-Fedora" comes from investigating the other packages ...

"X-Red-Hat-Extra" comes from the documentation: 
http://docs.fedoraproject.org/developers-guide/ch-menus.html#s1-categories

if this is no longer valid then it should be updated


Spec URL: http://sn.bluehost.cz/tmp/no-mp3/qmmp.spec (overwritten with new 
version)
SRPM URL: http://sn.bluehost.cz/tmp/no-mp3/qmmp-0.1.4-2.fc7.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.