[Bug 280751] Review Request: qmmp - Qt-based multimedia player

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: qmmp - Qt-based multimedia player


https://bugzilla.redhat.com/show_bug.cgi?id=280751





------- Additional Comments From bugs.michael at gmx.net  2007-09-11 20:22 EST -------
* missing "BuildRequires: cmake"

* not building with $RPM_OPT_FLAGS / %{optflags}
  (run  make VERBOSE=1  to see)

* hint: http://fedoraproject.org/wiki/Packaging/cmake

* licence seems to be GPLv2+
  source files contain the "or any later version" phrase)

* build failed here due to SMP make flags:

...
[ 24%] Building CXX object lib/CMakeFiles/qmmp.dir/moc_iir.o
/usr/bin/ld: cannot find -lqmmp
collect2: ld returned 1 exit status
make[2]: *** [lib/qmmp/Input/vorbis/libvorbis.so] Error 1
make[1]: *** [lib/qmmp/Input/vorbis/CMakeFiles/vorbis.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....

* dropping the %{_smp_mflags} make the build-job succeed

* GPLv2 text is not included! (only compiled in)

* shared libraries are not chmod +x

* rpmlint qmmp-0.1.4-2.fc8.i386.rpm
qmmp.i386: E: invalid-soname /usr/lib/libqmmp.so libqmmp.so
 => acceptable during development, but it requires strictly
  versioned "Requires" in plugin packages

* package provides SONAMEs it must not provide except
for "libqmmp.so":

$ rpm -qp --provides qmmp-0.1.4-2.fc8.i386.rpm | grep lib
libalsa.so  
libflac.so  
libjack.so  
libmpc.so  
libqmmp.so  
libvorbis.so  

The others come from the plugin libraries. It is highly
recommended to filter them out as not to disturb what
legitimate library packages provide/require.

http://fedoraproject.org/wiki/PackagingDrafts/FilteringAutomaticDependencies


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.