[Bug 469471] Review Request: skinlf - Java look and feel for swing

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=469471





--- Comment #11 from D Haley <mycae at yahoo.com>  2008-12-03 08:11:12 EDT ---
SPEC URL: http://dhd.selfip.com/427e/skinlf-5.spec
SRPM URL: http://dhd.selfip.com/427e/skinlf-6.7-5.fc9.srpm

RPMLint on SRPM, SPEC and RPM are empty

>* Also, add "LICENSE_nanoxml" to %doc.
Done.

> If src/examples/Clock.java is needed, I will ask spot whether the
> license is free or not.
Done. Removed by deletion in %prep -- the examples are only compressed into the
jar and are not required at compile. 

Q: How do I provide the srpm? With Clock.java or without -- if I make it with,
it still contains it (just not the RPM). If I make it without then it will
require me to recompress the source tarball, making the Source0 line invalid. 

> (and also any .jar.dll files)
Not needed/implicit. The output of find ./ -name  blah, where blah is *.jar,
*so and *dll, is empty. This was the case for the prior revision. The prior
revision included the standard check for java files from the packaging
guidelines to ensure that the package will not build if any file *.jar is
located within the build tree. This check is performed at %prep time.

> BuildRequires, Requires
Done. Imported any missing java deps from previous package "laf-plugin".
Specifically jpackage-utils and updated java lines for req & buildreq.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.