[Bug 469471] Review Request: skinlf - Java look and feel for swing

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=469471


Sandro Mathys <red at fedoraproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |red at fedoraproject.org




--- Comment #12 from Sandro Mathys <red at fedoraproject.org>  2008-12-05 18:17:56 EDT ---
just two things I noticed (I'm about to create a package that will depend on
skinlf):

1) there jar should be named %{name}-%{version}.jar with a symlink %{name}.jar
to it. Right now, only %{name}.jar is installed to the %{_javadir}. ls -al
/usr/share/java will show you, that (most?) packages do it like that.

2) the jar should contain the class files, not the source files ;)

instead of:
pushd .
cd build/src
jar cf %{name}-%{version}.jar .
popd

do:
pushd build/classes
jar cf %{name}-%{version}.jar .
popd

of course, you'll need to change the path in the install cmd after that, too.

I've tested that change and it works fine.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.