[Bug 446841] Review Request: python-sippy - B2BUA SIP call controlling component

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=446841





--- Comment #4 from Jason Tibbitts <tibbs at math.uh.edu>  2008-12-06 21:50:27 EDT ---
I'm sorry for not looking at this ticket in so many months.  The review queue
is just so long....

Unfortunately the package in comment 3 doesn't build for me:

Executing command: ['bash', '--login', '-c', 'rpmbuild -bs --target x86_64
--nodeps builddir/build/SPECS/python-sippy.spec']
error: %patch without corresponding "Patch:" tag

You have Patch0: but call %patch instead of %patch0.  rpm these days doesn't
permit that.

You can probably drop the BuildRequires conditional for Fedora 8; new branches
for that release aren't accepted any longer so you only have to consider F-9
and newer.

If I fix the %patch problem, the package builds and rpmlint says:
  python-sippy.src:13: W: unversioned-explicit-provides sippy
You should essentially never use an unversioned Provides: like that, because it
makes it impossible to bring back a package with that name.  See
https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Renaming.2Freplacing_existing_packages
for more information on how to rename packages.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.