[Bug 466717] Review Request: python-cvxopt - A Python Package for Convex Optimization

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=466717


Orcan 'oget' Ogetbil <orcanbahri at yahoo.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |orcanbahri at yahoo.com
               Flag|                            |fedora-review?




--- Comment #7 from Orcan 'oget' Ogetbil <orcanbahri at yahoo.com>  2008-12-08 21:24:28 EDT ---
OK, there are a few things that need attention. Otherwise everything seems
good.

* There is a bunch of compiled C code in the package (under src/C/SuiteSparse).
Some are released under GPLv2+, others under LGPLv2+. So I think the correct
license tag should be "GPLv3+ and LGPLv2+". Also there are lots of doc files
inside subdirectories of this directory. They need to be packaged.

* There is also a doc directory right on the root of the tarball that contains
a Makefile. I think that these docs should be built and included in the
package. You'll probably need to BR some latex package(s) for this.

* rpmlint gives a huge amount of warnings and errors. There are basically two
types of these:
    W: doc-file-dependency
    W: spurious-executable-perm
There are two ways to fix these. Either, change the permissions of these files
to 644, OR (the way I'd prefer) put the examples directory inside
%{_datadir}/%{name}.

! This package softly depends on pymosek which is proprietary software. But
since it is not a direct requirement, this can't be a blocker.

* Python eggs are handled a little differently for non-setuptools packages. In
order to create the python egg the proper way, please follow the example in
this guideline:
  
http://fedoraproject.org/wiki/Packaging/Python/Eggs#Providing_Eggs_for_non-setuptools_packages

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.