[Bug 466717] Review Request: python-cvxopt - A Python Package for Convex Optimization

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=466717





--- Comment #8 from Conrad Meyer <konrad at tylerc.org>  2008-12-08 22:40:36 EDT ---
(In reply to comment #7)
> * Also there are lots of doc files
> inside subdirectories of this directory. They need to be packaged.

Hm, which subdirectories?

> * There is also a doc directory right on the root of the tarball that contains
> a Makefile. I think that these docs should be built and included in the
> package. You'll probably need to BR some latex package(s) for this.

OK.

> * rpmlint gives a huge amount of warnings and errors. There are basically two
> types of these:
>     W: doc-file-dependency
>     W: spurious-executable-perm
> There are two ways to fix these. Either, change the permissions of these files
> to 644, OR (the way I'd prefer) put the examples directory inside
> %{_datadir}/%{name}.

OK.

> * Python eggs are handled a little differently for non-setuptools packages. In
> order to create the python egg the proper way, please follow the example in
> this guideline:
>   
> http://fedoraproject.org/wiki/Packaging/Python/Eggs#Providing_Eggs_for_non-setuptools_packages

Oh, oops. I've done this correctly before, it just slipped my mind. Thanks for
pointing this out.

New URLs to address the criticisms mentioned in the previous comment (I'm still
unsure what you mean by commented quoted first above):

http://konradm.fedorapeople.org/fedora/SPECS/python-cvxopt.spec
http://konradm.fedorapeople.org/fedora/SRPMS/python-cvxopt-1.1-2.fc9.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.