[Bug 473348] Review Request: drraw - Web based presentation front-end for RRDtool

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=473348


Chris St. Pierre <stpierre at nebrwesleyan.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |stpierre at nebrwesleyan.edu




--- Comment #1 from Chris St. Pierre <stpierre at nebrwesleyan.edu>  2008-12-23 00:18:25 EDT ---
This is not an official review.

1.  When applying patch #2, patch returns:

patch unexpectedly ends in middle of line

While this doesn't abort the build, the patch file should be fixed to not
generate this error.

2.  This would fail to run with SELinux activated. You should fix the context
of the CGI script, per http://fedoraproject.org/wiki/PackagingDrafts/SELinux. 
Creating a drraw-selinux subpackage would probably be ideal in this case.

3.  Patch #2 appears to be a bug fix.  If you have filed a bug with the
upstream source, you should reference this in your spec file; if not, you
should file one and reference it.  See
http://fedoraproject.org/wiki/Packaging/Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.