[Bug 225669] Merge Review: ctags

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: ctags


https://bugzilla.redhat.com/show_bug.cgi?id=225669


terjeros at phys.ntnu.no changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |NEW
               Flag|needinfo?                   |




------- Additional Comments From terjeros at phys.ntnu.no  2008-02-15 15:57 EST -------
( > * Both Summary and description should be reworked, they don't match the 
> >package as of today.
> 
> what is the problem here? could you please give more infos?

The summary and description only talks about C code, however
ctags now supports a lot of program languages:

http://ctags.sourceforge.net/languages.html

This fact should be stated in the summary and description, from the the website.

Something along the lines of the rpm from the website maybe:

Summary:

Exuberant Ctags - a multi-language source code indexing tool

Desc:

Exuberant Ctags generates an index (or tag) file of language objects
found in source files for many popular programming languages. This index
makes it easy for text editors and other tools to locate the indexed
items. Exuberant Ctags improves on traditional ctags because of its
multilanguage support, its ability for the user to define new languages
searched by regular expressions, and its ability to generate emacs-style
TAGS files.

Install ctags if you are going to use your system for programming.



> the old changelog should be remained

Ok.
 
> i prefer %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

Fine.
 
> >+ License: ok

The guidelines has changed since the initial review, the license is in fact not
valid, please have a  look at this issue.

> >+ American English: ok, however as noted the summary and description is 
> >outdated
> >and should be fixed.
> 
> any idea how to fix it?

See over?
 
> >Then a issue maybe outside the scope of this review, I really like to see 
> >etags
> >enabled and
> >included. Perhaps in a ctags-etags subpackage like this:
> >
> it doesn't make sense to add redundant etags here.
> wont fix

I don't see the problem in including a ctags-etags subpackage for users that
will swap GNU Emacs / XEmacs etags for Exuberant Ctags etags.

I have created a ctags package with a ctags-etags subpackage. The correct
alternatives commands are used. A patch is included as attachment.

Please reconsider for inclusion.




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.