[Bug 432542] Review Request: autogen - Automated text file generator

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: autogen - Automated text file generator


https://bugzilla.redhat.com/show_bug.cgi?id=432542





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2008-02-22 11:55 EST -------
For 5.9.4-2:

* autogen-manuals
  - new autogen package should "obsolete" this package.

? BR: chrpath
  - Well, would you try to remove rpath by not using chrpath?
    ("Removing Rpath" of
      http://fedoraproject.org/wiki/Packaging/Guidelines )
    Using chrpath should be considered as a last resort..

    Usually modifying libtool (or make LIBTOOL=%{_bindir}/libtool)
    removes rpath.

* License tag
  (See License-check.log)
  - Actually as %{_includedir}/autoopts/options.h (and so on)
    is LGPLv3+, "BSD or" part must be deleted.

* defattr
  - We now recommend %defattr(-,root,root,-)

* pkgconfig file
  - Well, autoopts.pc file contains
-------------------------------------------------------------
    11  ldopts="-Wl,-R"
    25  Libs:           -Wl,-R/usr/lib -L/usr/lib -lopts
-------------------------------------------------------------
    "-Wl,-R" sets rpath and this must be deleted.

! multilib conflict
  - autoopts/autoopts-config.in contains 
-------------------------------------------------------------
    20        libdir="@libdir@"
-------------------------------------------------------------
    or so, which differs between on 32bit arch and on 64bit arch.
    So this causes multilib conflict. Please try to resolve this
    conflict.
    http://fedoraproject.org/wiki/PackagingDrafts/MultilibTricks

* Undefined non weak symbols
  - libguileopts.so has undefined non-weak symbols
    From rpmlint (on i386):
-------------------------------------------------------------
autogen-libopts.i386: W: undefined-non-weak-symbol
/usr/lib/libguileopts.so.0.0.1 scm_i_master_freelist
autogen-libopts.i386: W: undefined-non-weak-symbol
/usr/lib/libguileopts.so.0.0.1 scm_i_master_freelist2
autogen-libopts.i386: W: undefined-non-weak-symbol
/usr/lib/libguileopts.so.0.0.1 scm_cells_allocated
autogen-libopts.i386: W: undefined-non-weak-symbol
/usr/lib/libguileopts.so.0.0.1 scm_i_freelist
autogen-libopts.i386: W: undefined-non-weak-symbol
/usr/lib/libguileopts.so.0.0.1 scm_i_freelist2
autogen-libopts.i386: W: undefined-non-weak-symbol
/usr/lib/libguileopts.so.0.0.1 scm_gc_for_newcell
autogen-libopts.i386: W: undefined-non-weak-symbol
/usr/lib/libguileopts.so.0.0.1 gh_eval_str
-------------------------------------------------------------
    ( you can check this also by "ldd -r /usr/lib/libguileopts.so")

    libguileopts.so is in -devel package, i.e. used for linkage
    so leaving these symbols is not allowed because this causes
    linkage failure.

* scriptlets
  - For /sbin/install-info, for some reason Fedora requests
    to use
--------------------------------------------------------------
/sbin/install-info %{_infodir}/%{name}.info %{_infodir}/dir || :
                                         ^^^^
--------------------------------------------------------------
    http://fedoraproject.org/wiki/Packaging/ScriptletSnippets

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.