[Bug 432542] Review Request: autogen - Automated text file generator

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: autogen - Automated text file generator


https://bugzilla.redhat.com/show_bug.cgi?id=432542





------- Additional Comments From debarshi.ray at gmail.com  2008-02-24 12:34 EST -------
(In reply to comment #11)

> * autogen-manuals
>   - new autogen package should "obsolete" this package.

Fixed.
 
> ? BR: chrpath
>   - Well, would you try to remove rpath by not using chrpath?
>     ("Removing Rpath" of
>       http://fedoraproject.org/wiki/Packaging/Guidelines )
>     Using chrpath should be considered as a last resort..

+ there is no --disable-rpath option in configure
+ using sed to modify libtool as shown in Wiki causes build failure

Is it worth trying to modify the code/Makefiles as mentioned in the Wiki? I did
not try it because they say it is "not always easy or sane to do".

> * License tag
>   (See License-check.log)
>   - Actually as %{_includedir}/autoopts/options.h (and so on)
>     is LGPLv3+, "BSD or" part must be deleted.

Changed dual licensing of autogen-libopts-devel by dropping BSD.
 
> * defattr
>   - We now recommend %defattr(-,root,root,-)

Fixed.
 
> * pkgconfig file
>   - Well, autoopts.pc file contains
> -------------------------------------------------------------
>     11  ldopts="-Wl,-R"
>     25  Libs:           -Wl,-R/usr/lib -L/usr/lib -lopts
> -------------------------------------------------------------
>     "-Wl,-R" sets rpath and this must be deleted.

Fixed.

> ! multilib conflict
>   - autoopts/autoopts-config.in contains 
> -------------------------------------------------------------
>     20        libdir="@libdir@"
> -------------------------------------------------------------
>     or so, which differs between on 32bit arch and on 64bit arch.
>     So this causes multilib conflict. Please try to resolve this
>     conflict.
>     http://fedoraproject.org/wiki/PackagingDrafts/MultilibTricks

Ok. However, some pkgconfig files (eg., cairo.pc) have:
[...]
libdir=/usr/lib64
[...]
Libs: -L${libdir} -lcairo
[...]
 
Since the above write-up is a draft, I just want to confirm from you.

> * Undefined non weak symbols
>   - libguileopts.so has undefined non-weak symbols

Fixed.

> * scriptlets
>   - For /sbin/install-info, for some reason Fedora requests
>     to use

Fixed.

Spec: http://rishi.fedorapeople.org/autogen.spec
SRPM: http://rishi.fedorapeople.org/autogen-5.9.4-3.fc8.src.rpm

Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=466283

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.