[Bug 428549] Review Request: trac-monotone-plugin - Monotone version control plugin for Trac

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: trac-monotone-plugin - Monotone version control plugin for Trac


https://bugzilla.redhat.com/show_bug.cgi?id=428549





------- Additional Comments From geoff at programmer-monk.net  2008-01-13 21:58 EST -------
This is my first review attempt so I'm probably going to miss something but I'm trying to get some 
experience with the fedora procedures.

ok MUST: rpmlint output

trac-monotone-plugin.noarch: E: non-executable-script /usr/lib/python2.5/site-
packages/tracmtn/basic_io.py 0644
trac-monotone-plugin.noarch: E: non-executable-script /usr/lib/python2.5/site-
packages/tracmtn/automate.py 0644
trac-monotone-plugin.noarch: E: non-executable-script /usr/lib/python2.5/site-
packages/tracmtn/cache.py 0644
trac-monotone-plugin.noarch: E: non-executable-script /usr/lib/python2.5/site-
packages/tracmtn/backend.py 0644
trac-monotone-plugin.noarch: E: non-executable-script /usr/lib/python2.5/site-
packages/tracmtn/util.py 0644
trac-monotone-plugin.noarch: E: non-executable-script /usr/lib/python2.5/site-
packages/tracmtn/__init__.py 0644

Seems silly to patch these out, I would consider asking upstream to remove the
shebangs since it doesn't look like these are inteded to be executed.

ok MUST: name follows naming guidelines
ok MUST: spec file matches package name
ok MUST: The package must meet the Packaging Guidelines.
ok MUST: license is acceptable
ok MUST: license is correct
ok MUST: license file included in doc
ok MUST: The spec file must be written in American English.
ok MUST: spec file is readable
NO MUST: source matches upstream

The instructions for retrieving the source from the upstream vcs does not
specify a specific tag or revision.  This makes it impossible to verify the
source.

ok MUST: package builds successfully
NO MUST: BuildRequires is complete

trac is required at build because it is imported (indirectly) from setup.py

ok MUST: owns created directories 
ok MUST: A package must not contain any duplicate files in the %files listing.
ok MUST: permssions are correct
ok MUST: clean removes buildroot
ok MUST: macros used consistently
ok MUST: package contains code or permissable content
ok MUST: package does not depend on %doc files
ok MUST: doesn't own other package's files
ok MUST: install preps buildroot
ok MUST: All filenames in rpm packages must be valid UTF-8.

SHOULD Items:

NO SHOULD: builds in mock

See above regarding buildrequires

ok SHOULD: package works properly



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.