[Bug 428549] Review Request: trac-monotone-plugin - Monotone version control plugin for Trac

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: trac-monotone-plugin - Monotone version control plugin for Trac


https://bugzilla.redhat.com/show_bug.cgi?id=428549


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tibbs at math.uh.edu




------- Additional Comments From tibbs at math.uh.edu  2008-01-15 20:32 EST -------
Interesting that this build for Geoff, because it doesn't build for me.  Geoff,
did you do a mock build?  Against which version of Fedora did you build?

In mock, building against current rawhide repositories, I get:

+ /usr/bin/python setup.py build
Traceback (most recent call last):
  File "setup.py", line 28, in <module>
    from tracmtn import __version__ as VERSION
  File "/builddir/build/BUILD/TracMonotone-0.0.12/tracmtn/__init__.py", line 6,
in <module>
    import backend
  File "/builddir/build/BUILD/TracMonotone-0.0.12/tracmtn/backend.py", line 28,
in <module>
    from trac.versioncontrol.api import Repository, Node, Changeset, \
ImportError: No module named trac.versioncontrol.api
error: Bad exit status from /var/tmp/rpm-tmp.54163 (%build)

I added a build-time depenency on trac and the package builds.

I'll concurr with Geoff about the non-executable-script rpmlint complaints. 
Python programmers do this for some unknown reason and I'm long past blocking
packages because of it.

Wow, this is significantly broken; you can't even use setup.py to create the
tarball without having trac installed.  Really suboptimal.

I did the checkout as instructed in the spec and the content I get differs.  I
think it's important to specify a date or a tag or whatever monotone supports to
ensure that we can get a consistent checkout in the absense of an actual release
tarball.

On the plus side, it looks like many of the shebang lines are gone in the
checkout I made.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.