[Bug 429085] Review Request: libfishsound - Simple programming interface for Xiph.Org codecs

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libfishsound - Simple programming interface for Xiph.Org codecs


https://bugzilla.redhat.com/show_bug.cgi?id=429085





------- Additional Comments From michel.sylvan at gmail.com  2008-01-18 11:20 EST -------
Spec URL: http://salimma.fedorapeople.org/for_review/music/libfishsound.spec
SRPM URL:
http://salimma.fedorapeople.org/for_review/music/libfishsound-0.9.0-2.fc8.src.rpm

> Builds OK; rpmlint says:
>   libfishsound.src: W: mixed-use-of-spaces-and-tabs
>    (spaces: line 1, tab: line 34)

Woops. Forgot to untabify it. Must have used vim for a quick edit at some point.


>   libfishsound.x86_64: W: unused-direct-shlib-dependency
>    /usr/lib64/libfishsound.so.1.3.0 /usr/lib64/libogg.so.0
>   libfishsound.x86_64: W: unused-direct-shlib-dependency 
>    /usr/lib64/libfishsound.so.1.3.0 /lib64/libm.so.6
> libfishsound.so is linked against libm and libogg even though it doesn't call
> any functions in them.  Nice to fix them if you can, but not absolute blockers
> if you can't.

Will check. It supposedly depends on liboggz as well, but the binary package
does not seem to have any dependency on it, I just noticed. Will probably
manually add it for now and check with upstream.

(What version of rpmlint do you use? Mine did not pick up this problem)


> The guidelines recommend -doc over -docs for the documentation.  (I keep
> screwing this up myself.)

Woops, did that with another package as well.

> There's a typo in the URL tag; it needs another 'n'.
Fixed

> Is it true that this software supports FLAC as the description says?  The
> "currently non-functional" comment in the spec would seem to indicate
> otherwise.
The configure script fails on current versions of FLAC. If I bypass the check,
compilation fails anyway. This is due to the API change in FLAC 1.1.2, I believe
-- there've been other packages (can't remember which right now) that
encountered this issue.



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.