[Bug 429085] Review Request: libfishsound - Simple programming interface for Xiph.Org codecs

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libfishsound - Simple programming interface for Xiph.Org codecs


https://bugzilla.redhat.com/show_bug.cgi?id=429085


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From tibbs at math.uh.edu  2008-01-18 23:13 EST -------
The liboggz dependency you added has caused:
  libfishsound.x86_64: E: explicit-lib-dependency liboggz
I honestly don't know what's up; you can see -loggz on the link lines but it
doesn't show up in the resulting library (ldd shows no dependency) and of course
rpmbuild doesn't find anything.  Maybe it gets pulled in dynamically or
something, although I didn't find any evicence of that.

One thing I did notice is that oggz headers are only included in the example
programs; maybe that's it.

BTW, you need to run rpmlint on the installed package in order to see a small
class of warnings including those unused-direct-shlib-dependency complaints.  My
build scripts install the package (and rpmlint) into the mock chroot after
building so I can test installability and get those few extra rpmlint checks.

So, at this point everything is fixed but the liboggz thing is weird.  I'll just
approve this package and you can sort out the oggz bit at your leisure.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.