[Bug 428369] Review Request: nec2c - a translation of the Numerical Electromagnetics Code (NEC2)

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: nec2c -  a translation of the Numerical Electromagnetics Code (NEC2)


https://bugzilla.redhat.com/show_bug.cgi?id=428369





------- Additional Comments From tibbs at math.uh.edu  2008-01-26 15:30 EST -------
* source files match upstream:
   2acac418ed0be47bf282474af403b698841cc2307d46d3a5e4dde41e03dceab5  
   nec2c-0.6.tar.gz
 package meets naming and versioning guidelines.
 specfile is properly named, is cleanly written and uses macros consistently.
 summary is OK.
 description is OK.
 dist tag is present.
 build root is OK.
 license field matches the actual license.
 license is open source-compatible.
 license text not included upstream.
 license text included in package.
 latest version is being packaged.
 BuildRequires are proper.
 compiler flags are appropriate.
 %clean is present.
 package builds in mock ( ).
 package installs properly
 debuginfo package looks complete.
 rpmlint is silent.
 final provides and requires are sane:

 %check is present and all tests pass:

 no shared libraries are added to the regular linker search paths.
 owns the directories it creates.
 doesn't own any directories it shouldn't.
 no duplicates in %files.
 file permissions are appropriate.
 no scriptlets present.
 code, not content.
 documentation is small, so no -doc subpackage is necessary.
 %docs are not necessary for the proper functioning of the package.
 no headers.
 no pkgconfig files.
 no static libraries.
 no libtool .la files.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.