[Bug 428369] Review Request: nec2c - a translation of the Numerical Electromagnetics Code (NEC2)

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: nec2c -  a translation of the Numerical Electromagnetics Code (NEC2)


https://bugzilla.redhat.com/show_bug.cgi?id=428369


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |tibbs at math.uh.edu
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review+




------- Additional Comments From tibbs at math.uh.edu  2008-01-26 16:13 EST -------
Hmm, seems I errantly clicked Save Changes.  Weird.  Anyway, here's the actual
review:

I talked with Bob about this package at fudcon but the suggested fix doesn't
seem to have made it.  No matter, it's trivial.

The debuginfo package comes out empty because the compiler isn't called
properly.  Fixing it is triviak; just change %build to:
  make CFLAGS="%{optflags}" %{?_smp_mflags}
and everything comes out OK.  Of course you should test that this doesn't
somehow break things.

Honestly, though, that's a trivial change.  I'll approve it and you can fix it
up when you check in.

* source files match upstream:
   2acac418ed0be47bf282474af403b698841cc2307d46d3a5e4dde41e03dceab5  
   nec2c-0.6.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* latest version is being packaged.
* BuildRequires are proper.
X compiler flags are not correct.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly
X debuginfo package is incomplete.
* rpmlint is silent.
* final provides and requires are sane:
   nec2c = 0.6-1.fc9
  =
   (nothing besides libc)
* %check is not present; no test suite upstream.  I haven't a clue how to test 
   this, but installed the resulting package and it at least runs and gives a 
   usage message.
* no shared libraries are added to the regular linker search paths.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no static libraries.
* no libtool .la files.

APPROVED, just add CFLAGS to the make line when you check in.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.