[Bug 453701] Review Request: minisat2 - A minimalistic, open-source SAT solver

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: minisat2 -  A minimalistic, open-source SAT solver


https://bugzilla.redhat.com/show_bug.cgi?id=453701


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |tibbs at math.uh.edu
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review?




------- Additional Comments From tibbs at math.uh.edu  2008-07-04 15:03 EST -------
This looks mostly good to me.  It's unfortunate to see that some people seem to
have forgotten what happened a little under nine years ago and have fallen back
to using two-digit years, but that's not up to you.

I think the package in Debian is named minisat2 because that's actually the name
of the software according to upstream, and of course that's the best name to use.

Please consistently use the macro-ized forms; either use things like "cp -p" or
use "%{cp_p}" but don't use both.  (You have two macro forms in %install.) 
Personally I don't see the point in the extra typing that comes with the macros,
but it's your choice; you just need to be consistent.

Please add comments on the upstream status of the included patches. 
http://fedoraproject.org/wiki/Packaging/PatchUpstreamStatus

Nice touch providing documentation, although it would be good if that was sent
upstream as well.

It's interesting that a few source files aren't in the debuginfo package; it
looks like they're just dead code (e.g. BasicHeap.h isn't referenced anywhere).

* source files match upstream:
  ddc2ed421a538a349ddab58d3958076d73813925ff08361e6292583d3b87248e  
   minisat2-070721.zip
  c02847f5dedcf757917a8dd321a8314d1d21268f54823e17ef392311d539afe1  
   minisat-user-guide-1.0.html
* package meets naming and versioning guidelines.
* specfile is properly named and is cleanly written.
X specfile does not use macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* compiler flags are appropriate.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* debuginfo package looks complete.
* rpmlint is silent.
* final provides and requires are sane:
   minisat2 = 070721-3.fc10
  =
   libgcc_s.so.1()(64bit)
   libgcc_s.so.1(GCC_3.0)(64bit)
   libstdc++.so.6()(64bit)
   libstdc++.so.6(CXXABI_1.3)(64bit)
   libz.so.1()(64bit)

* %check is present and all tests pass.
* no shared libraries are added to the regular linker search paths.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no static libraries.
* no libtool .la files.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.