[Bug 453701] Review Request: minisat2 - A minimalistic, open-source SAT solver

bugzilla at redhat.com bugzilla at redhat.com
Sat Jul 5 02:29:28 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: minisat2 -  A minimalistic, open-source SAT solver


https://bugzilla.redhat.com/show_bug.cgi?id=453701





------- Additional Comments From dwheeler at dwheeler.com  2008-07-04 22:29 EST -------
Thanks SO MUCH for reviewing the package! I'll fix the "specfile does not use
macros consistently" issue. (Thanks, I hadn't noticed that.)  I'll just switch
to normal commands and not macros for them.

I'm not fond of upstream's version system either.  If you're going to use a
date, use YYYYMMDD!  I'm thinking of changing the version field to "2.0" and
placing the date in the release value instead (treating it as if it were an
"interim" release): 0.1.YYYYMMDD or some such.  That way, if they switch back to
a more traditional version numbering system, no epoch will be needed.  Sound
reasonable?

> Nice touch providing documentation, although it would be good if that was sent
upstream as well.

Thanks!  I agree with getting the docs upstream, that was my plan anyway. (I'm
treating the added documentation as a patch.)  It's ridiculous to create a
program with NO documentation of any kind, yet this sure isn't the only one :-(.



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the Fedora-package-review mailing list